Validating for broken index #544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:XS
nadolskit
approved these changes
Oct 8, 2024
dosubot
bot
added
lgtm
jamesbraza
force-pushed
the
validating-nonempty-index
branch
5 times, most recently
from
c4dd18e
to
9b285a1
Compare
jamesbraza
force-pushed
the
validating-nonempty-index
branch
from
9b285a1
to
8bfa3b4
Compare
mskarlin
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the
files.zipis not present, the index will be empty. Then with an empty index, our environment will complete a rollout with 0% performance.This PR add a validation to
build=Falseforpaper_searchthat the index actually has files present, preventing silent failures.